Patch Pilot report

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Gary van der Merwe wrote:
> On 04/12/2009 10:01, Martin Pool wrote:
>> There was some confusion about whether people should click the
>> 'resubmit' button when they redo their patch or not.  'Resubmit'
>> essentially wipes the slate clean.  I think generally speaking it's
>> better just to push a new update.
> 
> But then the diff does not update, and it does not inform the reviews
> that there is a change.
> 
> I feel the launchpad could really be improved here. If the tip of the
> branch changes, it should note that in the messages, and update the
> diff. I'll log a bug about this later.
> 
> 

Launchpad does update the diff, but not until the hosted branch gets
mirrored. (And probably some further delay for it to regenerate the diff
itself.)

As for the messages...

I marked one submission resubmit because it was pretty much an entirely
different submission. Same concept, different implementation, so the
earlier comments didn't really apply.

Normally I do just push and then send a message/update the status
appropriately.

Though it is a bit odd to have a "Needs Fixing" vote on an item which
has been fixed...

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksZHsEACgkQJdeBCYSNAAOowgCbBgHsHrVmbpBLeMC3HJ8jUe2n
jgoAoIYldhtlhEAJAXi9ZcuRoEcePL+S
=R//I
-----END PGP SIGNATURE-----