[Bug 572098] Re: `bzr clean-tree` should not blindly delete nested branch/tree/repo

[Launchpad Bug Tracker]

This bug was fixed in the package bzr - 2.1.4-0ubuntu1

---------------
bzr (2.1.4-0ubuntu1) lucid-proposed; urgency=low

  * Update watch file to use 2.1 series.
  * New upstream release.
   + Fix file descriptors leaks in dirstate compiled extension. LP: #583486
   + Refuse to stack on repositories in incompatible formats. LP: #562380
   + Don't delete nested trees/repos. LP: #572098
   + Fix 'bzr switch' crash when a 'ConfigurableFileMerger' is used. LP: #559436
   + Fix compatibility with older smart servers. LP: #528041
   + Fix symlinks addition. LP: #192859
   + Properly unversion children of unversioned directories. LP: #494221
   + Lock configuration files in '~/.bazaar' for updates. LP: #525571
   + Fix 'bzr commit <symlink>'. LP: #128562
   + Fix `lp:` urls when behind an http proxy. LP: #558343
   + Stop using edge.launchpad.net. LP: #583667
 -- Max Bowsher <_ at maxb.eu>   Tue, 17 May 2011 09:54:17 +0100

** Changed in: bzr (Ubuntu Lucid)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to bzr in Ubuntu.
https://bugs.launchpad.net/bugs/572098

Title:
  `bzr clean-tree` should not blindly delete nested branch/tree/repo

Status in Bazaar Version Control System:
  Fix Released
Status in Bazaar 2.1 series:
  Fix Released
Status in “bzr” package in Ubuntu:
  Fix Released
Status in “bzr” source package in Lucid:
  Fix Released

Bug description:
  C:\Temp\1>bzr init .
  Created a standalone tree (format: 1.9)
  C:\Temp\1>bzr init foo
  Created a standalone tree (format: 1.9)
  C:\Temp\1>bzr st
  unknown:
    foo/
  C:\Temp\1>bzr clean-tree
  foo
  Are you sure you wish to delete these [y/N]?y
  deleting paths:
     foo

  I don't think it's the right behavior. I'd even call it dangerous
  behavior. Currently I've forced to stop using clean-tree command at
  all, because it affects both scmproj and bzr-externals plugins.

  I think it will be better to add another command-line flags, e.g.
  --nested, to enable deleting of nested bzr objects.

  I'd like to fix this, but I need some guidance on how reliable check
  that some given path is actually branch/tree/checkout/light
  checkout/shared repo and don't forgte about bzr-svn, bzr-git and so
  on.

  Will attempt to open bzrdir will be enough? If not, what API I should
  use?