[Bug 1783738] Re: _checkStoreConnectivity uses translatable strings for error checking

[Brian Murray]

Here are the test results from an Ubuntu 16.04 with an old version of
snapd and using the version of the dist-upgrader from bionic-proposed.

bdmurray at clean-xenial-amd64:~/u-r-u$ tail -n 20 /var/log/dist-
upgrade/screenlog.0

Outdated snapd package

Your system does not have the latest version of snapd. Please update 
the version of snapd on your system to improve the upgrade 
experience. 
Do you still want to continue with the upgrade? 

Continue [yN] -- 0:bionic -- time-stamp -- Aug/06/18 11:09:39 --
-- 0:bionic -- time-stamp -- Aug/06/18 11:13:02 --
N

Restoring original system state

Aborting
Reading package lists... Done    
Building dependency tree          
Reading state information... Done

=== Command detached from window (Mon Aug  6 11:13:04 2018) ===bdmurray at clean-xenial-amd64:~/u-r-u$ head -n20 /var/log/dist-upgrade/main.log 
2018-08-06 11:07:09,619 INFO Using config files '['./DistUpgrade.cfg.xenial']'
2018-08-06 11:07:09,619 INFO uname information: 'Linux clean-xenial-amd64 4.4.0-121-generic #145-Ubuntu SMP Fri Apr 13 13:47:23 UTC 2018 x86_64'
2018-08-06 11:07:09,923 INFO apt version: '1.2.26'
2018-08-06 11:07:09,924 INFO python version: '3.5.2 (default, Nov 23 2017, 16:37:01) 
[GCC 5.4.0 20160609]'
2018-08-06 11:07:09,926 INFO release-upgrader version '18.04.22' started


** Tags removed: verification-needed verification-needed-bionic
** Tags added: verification-done verification-done-bionic

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1783738

Title:
  _checkStoreConnectivity uses translatable strings for error checking

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Committed

Bug description:
  [Impact]
  There currently are not any translation files for snappy that I could find for Ubuntu 16.04, the release from which an upgrade would be happening, however those might be SRU'ed so its still worth fixing.

  [Test Case]
  Given that there are no translations of snappy in Ubuntu 16.04 yet we should just test that there are no regressions. This can be done by ensuring that you are running an old version of snapd which doesn't support the 'debug connectivity' command.

  [Regression Potential]
  Already addressed in the test case above.

  In DistUpgradeQuirks.py in _checkStoreConnectivity there is this code:

  451         elif 'error: unknown command' in connected[1]:
  [...]
  461         elif 'error: access denied' in connected[1]:

  These tests will fail in a non-english language. For example in
  French:

  u at vm:~$ snap debug xxx
  erreur : unknown command "debug", see 'snap help'
  u at vm:~$ snap debug connectivity
  erreur : access denied (essayez avec sudo)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1783738/+subscriptions