[Bug 1783738] Re: _checkStoreConnectivity uses translatable strings for error checking

[Launchpad Bug Tracker]

This bug was fixed in the package ubuntu-release-upgrader - 1:18.04.22

---------------
ubuntu-release-upgrader (1:18.04.22) bionic; urgency=medium

  * DistUpgradeQuirks.py:
    - make sure that snapd is installed before trying to use it.
      (LP: #1783589)
    - update the view with information regarding the progress of snaps being
      installed. (LP: #1783593)
    - when checking for connectivity to the snap store use C.UTF-8 for the
      language so error message matching works. (LP: #1783738)
  * DistUpgradeController.py:
    - Remove debs from apt's "Dir::Cache::archives" folder after the upgrade
      has completed successfully. (LP: #1785096)
    - Add a telemetry marker to report the time to process the migration from
      deb to snaps.

 -- Brian Murray <brian at ubuntu.com>  Thu, 02 Aug 2018 11:20:06 -0700

** Changed in: ubuntu-release-upgrader (Ubuntu Bionic)
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to ubuntu-release-upgrader in
Ubuntu.
https://bugs.launchpad.net/bugs/1783738

Title:
  _checkStoreConnectivity uses translatable strings for error checking

Status in ubuntu-release-upgrader package in Ubuntu:
  Fix Released
Status in ubuntu-release-upgrader source package in Bionic:
  Fix Released

Bug description:
  [Impact]
  There currently are not any translation files for snappy that I could find for Ubuntu 16.04, the release from which an upgrade would be happening, however those might be SRU'ed so its still worth fixing.

  [Test Case]
  Given that there are no translations of snappy in Ubuntu 16.04 yet we should just test that there are no regressions. This can be done by ensuring that you are running an old version of snapd which doesn't support the 'debug connectivity' command.

  [Regression Potential]
  Already addressed in the test case above.

  In DistUpgradeQuirks.py in _checkStoreConnectivity there is this code:

  451         elif 'error: unknown command' in connected[1]:
  [...]
  461         elif 'error: access denied' in connected[1]:

  These tests will fail in a non-english language. For example in
  French:

  u at vm:~$ snap debug xxx
  erreur : unknown command "debug", see 'snap help'
  u at vm:~$ snap debug connectivity
  erreur : access denied (essayez avec sudo)

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1783738/+subscriptions