[Bug 1829264] Re: incorrect separator for multiple ARP IP targets

Launchpad Bug Tracker 1829264 at bugs.launchpad.net
Thu Aug 22 01:13:47 UTC 2019


This bug was fixed in the package netplan.io - 0.98-0ubuntu1

---------------
netplan.io (0.98-0ubuntu1) eoan; urgency=medium

  * New upstream release: 0.98 (LP: #1840832)
    - Added new "feature flags" to identify new features
    - Added support for "use-domains" for DHCP overrides
    - Added support for setting IPv6 MTU Bytes (LP: #1671951)
    - Added a DBus interface to query and run 'netplan apply' via other apps
    - Various build system fixes
    - Improved validation for bonding modes
    - Added support for "hash:" for hashed 802.1x passwords (LP: #1819831)
    - Tolerate devices without a /sys path (LP: #1810043)
    - Fix incorrect separator for networkd with ARP IP targets (LP: #1829264)
  * debian/control: Add Build-Depends on libsystemd-dev for DBus feature, and
    on dbus-x11 for dbus-launch used in tests.

 -- Mathieu Trudel-Lapierre <cyphermox at ubuntu.com>  Wed, 21 Aug 2019
14:49:16 -0400

** Changed in: netplan.io (Ubuntu)
       Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to netplan.io in Ubuntu.
Matching subscriptions: foundations-bugs
https://bugs.launchpad.net/bugs/1829264

Title:
  incorrect separator for multiple ARP IP targets

Status in netplan:
  Fix Committed
Status in netplan.io package in Ubuntu:
  Fix Released

Bug description:
  https://github.com/CanonicalLtd/netplan/blob/ea47bd4e1c5319b1a624ea61c843ee96e7c128da/src/networkd.c#L208

  The separator used to add multiple ARP IP targets for the networkd
  renderer is ",".

  Unfortunately, networkd doesn't allow that, but rather expects
  whitespace:

  (in config_parse_arp_ip_target_address():)
  [...]
          for (;;) {
                  [...]
                  r = extract_first_word(&rvalue, &n, NULL, 0);

  extract_first_word's third parameter is const char *separators; where
  NULL is handled like so (src/basic/extract-word.c:37):

          if (!separators)
                  separators = WHITESPACE;

  Finally:

  src/basic/string-util.h:#define WHITESPACE        " \t\n\r"

  So; it doesn't handle commas for the list, just whitespace; so let's
  give it whitespace please :)

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1829264/+subscriptions



More information about the foundations-bugs mailing list