[Bug 1840995] Re: check_stamp() function of apt.systemd.daily should not assume interval is a number

[Julian Andres Klode]

Oh, yes, but that's incomplete, there's a ton of other places that need
adjusting too. In practice, the only non-number value supported is
always.

Fixed in https://salsa.debian.org/apt-
team/apt/commit/489da40d56075efaa28bfdcfb7b02b3bcc222323

** Changed in: apt (Ubuntu)
   Importance: Undecided => Medium

** Changed in: apt (Ubuntu)
       Status: New => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apt in Ubuntu.
https://bugs.launchpad.net/bugs/1840995

Title:
  check_stamp() function of apt.systemd.daily should not assume interval
  is a number

Status in apt package in Ubuntu:
  Fix Committed

Bug description:
  In the second half of the function there is

      # Calculate the interval in seconds depending on the unit specified
      if [ "${interval%s}" != "$interval" ] ; then
          interval="${interval%s}"
      elif [ "${interval%m}" != "$interval" ] ; then
          interval="${interval%m}"
          interval=$((interval*60))
      elif [ "${interval%h}" != "$interval" ] ; then
          interval="${interval%h}"
          interval=$((interval*60*60))
      else
          interval="${interval%d}"
          interval=$((interval*60*60*24))
      fi

  so, a variable might hold something like "1d", "100m", etc.

  Yet in the first there is a condition

      if [ "$interval" -eq 0 ]; then
          debug_echo "check_stamp: interval=0"
          # treat as no time has passed
          return 1
      fi

  which treats the value as a number and leads to

  /usr/lib/apt/apt.systemd.daily: 87: [: Illegal number: 20h

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1840995/+subscriptions