[Bug 1996040] Re: apport-unpack cannot load gitkraken crash report - 'ascii' codec can't decode byte 0xfc in position 56

[Andreas Hasenack]

I verified the test results and am satisfied that they show the executed
planned test case, and that the results are correct.

The package built correctly in all architectures and Ubuntu releases it
was meant for.

There are no DEP8 regressions.

There is no SRU freeze ongoing at the moment.

There is no halted phasing on the previous update.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to apport in Ubuntu.
https://bugs.launchpad.net/bugs/1996040

Title:
  apport-unpack cannot load gitkraken crash report - 'ascii' codec can't
  decode byte 0xfc in position 56

Status in Apport:
  Fix Released
Status in apport package in Ubuntu:
  Fix Released
Status in apport source package in Kinetic:
  Fix Released

Bug description:
  Impact
  ======

  apport-unpack and whoopsie-upload-all can crash when fed with a
  malformed problem report. They should print a proper error message
  instead of crashing. This bug does not happen that often, but the fix
  for this bug is the foundation for the fix for bug #1995100.

  Test Plan
  =========

  1. Create malformed report:
  ```
  printf 'AB\xfc:CD\n' > malformed.crash
  ```
  2. Try to unpack it:
  ```
  apport-unpack malformed.crash unpack
  ```

  It should print an error message instead of a stack trace.

  Where problems could occur
  ==========================

  The patch touches the problem report handling and therefore can affect
  apport-unpack, apport-bug, whoopsie-upload-all. The change is covered
  with tests and apport has a test suite running during build and as
  autopkgtest.

  Original report
  ===============

  The latest GitKraken client (8.10.2 x64) is crashed every minute in
  cycle when you doing a rebase. When I try to inspect crash log to find
  the reason, the apport-unpack is not be able to process it:

  /var/lib/apport/coredump$ sudo apport-unpack core._snap_gitkraken_199_usr_share_gitkraken_gitkraken.1000.5de91c04-23ab-45c8-933c-0466d56e9fad.135785.50225891 unpack
  [sudo] пароль для mingun:
  Traceback (most recent call last):
    File "/usr/bin/apport-unpack", line 59, in <module>
      pr.load(f, binary=False)
    File "/usr/lib/python3/dist-packages/problem_report.py", line 194, in load
      key = key.decode('ASCII')
  UnicodeDecodeError: 'ascii' codec can't decode byte 0xfc in position 56: ordinal not in range(128)

  Unfortunately, crash file is too big (~9GB) and does not compress
  further

To manage notifications about this bug go to:
https://bugs.launchpad.net/apport/+bug/1996040/+subscriptions