[Bug 2119693] Re: Erroneously-vendored C library causes build failures on higher C standards

[Max Gilmour]

-------Changes--------
This patch addresses the problem by removing vendored C libraries from the package — the vendored onig_sys crate now uses the system libonig-dev, and the vendored blake3 crate now uses the pure Rust implementation rather than relying on the included C library, which has also been removed.

Note that the orig tarball was also regenerated — see my previous
comment for the tarball itself.

-------Links-------
PPA: https://launchpad.net/~maxgmr/+archive/ubuntu/rustc-1.85-merge/+packages
Source: https://git.launchpad.net/~canonical-foundations/ubuntu/+source/rustc/log/?h=merge-1.85

-------Lintian-------
E: rustc-1.85 source: field-too-long Vendored-Sources-Rust (12547 chars > 5000)
E: rustc-1.85 source: unknown-file-in-debian-source [debian/source/lintian-overrides.in]
E: rustc-1.85 source: version-substvar-for-external-package Depends ${binary:Version} cargo-1.85 -> rustc [debian/control:306]
W: rustc-1.85 source: mismatched-override missing-license-paragraph-in-dep5-copyright debian/copyright mpl-2.0+ (*) [debian/source/lintian-overrides:19]
W: rustc-1.85 source: unknown-field Vendored-Sources-Rust
N: 0 hints overridden; 1 unused override
N: Some overrides were ignored.
N: Use --verbose for more information.

-------autopkgtests-------
amd64: https://autopkgtest.ubuntu.com/results/autopkgtest-questing-maxgmr-rustc-1.85-merge/questing/amd64/r/rustc-1.85/20250808_193311_b6508@/log.gz
arm64: https://autopkgtest.ubuntu.com/results/autopkgtest-questing-maxgmr-rustc-1.85-merge/questing/arm64/r/rustc-1.85/20250811_175914_91ef1@/log.gz
armhf: https://autopkgtest.ubuntu.com/results/autopkgtest-questing-maxgmr-rustc-1.85-merge/questing/armhf/r/rustc-1.85/20250808_193201_43dfc@/log.gz
ppc64el: https://autopkgtest.ubuntu.com/results/autopkgtest-questing-maxgmr-rustc-1.85-merge/questing/ppc64el/r/rustc-1.85/20250808_182821_c123d@/log.gz
s390x: https://autopkgtest.ubuntu.com/results/autopkgtest-questing-maxgmr-rustc-1.85-merge/questing/s390x/r/rustc-1.85/20250808_181946_4d1a7@/log.gz

** Patch added: "1-1.85.1+dfsg0ubuntu2-0ubuntu2.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/rustc-1.85/+bug/2119693/+attachment/5898337/+files/1-1.85.1+dfsg0ubuntu2-0ubuntu2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rustc-1.85 in Ubuntu.
https://bugs.launchpad.net/bugs/2119693

Title:
  Erroneously-vendored C library causes build failures on higher C
  standards

Status in rustc-1.85 package in Ubuntu:
  In Progress

Bug description:
  Newer versions of GCC cause problems with the oniguruma C library,
  which is bundled as a dependency of the vendored orig_sys crate. The
  higher C standard causes the oniguruma build to fail.

  This isn't a GCC problem — as I recently learned, it's advised to use
  system C libraries when possible. This bug will be fixed by replacing
  the vendored oniguruma C library with the libonig-dev package.

  One example of a failure caused by this issue is in a `rust-comrak`
  autopkgtest[1]:

  ```
  878s [onig_sys 69.8.1] cargo:warning=oniguruma/src/regparse.c:588:5: error: initialization of 'int (*)(void)' from incompatible pointer type 'int (*)(st_str_end_key *, st_str_end_key *)' [-Wincompatible-pointer-types]
  ```

  [1]:
  https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-
  questing/questing/armhf/r/rust-comrak/20250806_000912_1db42@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rustc-1.85/+bug/2119693/+subscriptions