[Bug 2119693] Re: Erroneously-vendored C library causes build failures on higher C standards

[Ubuntu Foundations Team Bug Bot]

The attachment "1-1.85.1+dfsg0ubuntu2-0ubuntu2.debdiff" seems to be a
debdiff.  The ubuntu-sponsors team has been subscribed to the bug report
so that they can review and hopefully sponsor the debdiff.  If the
attachment isn't a patch, please remove the "patch" flag from the
attachment, remove the "patch" tag, and if you are member of the
~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to rustc-1.85 in Ubuntu.
https://bugs.launchpad.net/bugs/2119693

Title:
  Erroneously-vendored C library causes build failures on higher C
  standards

Status in rustc-1.85 package in Ubuntu:
  In Progress

Bug description:
  Newer versions of GCC cause problems with the oniguruma C library,
  which is bundled as a dependency of the vendored orig_sys crate. The
  higher C standard causes the oniguruma build to fail.

  This isn't a GCC problem — as I recently learned, it's advised to use
  system C libraries when possible. This bug will be fixed by replacing
  the vendored oniguruma C library with the libonig-dev package.

  One example of a failure caused by this issue is in a `rust-comrak`
  autopkgtest[1]:

  ```
  878s [onig_sys 69.8.1] cargo:warning=oniguruma/src/regparse.c:588:5: error: initialization of 'int (*)(void)' from incompatible pointer type 'int (*)(st_str_end_key *, st_str_end_key *)' [-Wincompatible-pointer-types]
  ```

  [1]:
  https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-
  questing/questing/armhf/r/rust-comrak/20250806_000912_1db42@/log.gz

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/rustc-1.85/+bug/2119693/+subscriptions