[Bug 2095584] Re: open-iscsi: ubuntu-only test needs update for Python 3.13

[Christian Ehrhardt]

testlib is from a time several packages tried to establish a shared lib for tets functions.
But requirements diverged and so this never came to permanent good use.

Due to that in this particular case the broken code is just unused.
Which means the fix for the usage of crypt which is failing in the new python can just be removed.

For the "invalid escape sequence" one should use raw strings.

And in general there is a lot of unused code that can be removed.

I'll iterate on that a few times as breaks allow it and then propose a
streamlined form - not trying to fix all we see, but the issues at hand
and removing totally unused bits.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/2095584

Title:
  open-iscsi: ubuntu-only test needs update for Python 3.13

Status in open-iscsi package in Ubuntu:
  New
Status in python3-defaults package in Ubuntu:
  New

Bug description:
  open-iscsi fails its autopkgtest [1] when triggered by
  python3-defaults/3.13.1-1~exp2 (i.e. with python3.13 as the default
  Python interpreter).

  348s autopkgtest [10:06:35]: test testsuite: [-----------------------
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:151: SyntaxWarning: invalid escape sequence '\s'
  349s   if re.search("^\s*%s\s*=" % (field), line):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:170: SyntaxWarning: invalid escape sequence '\s'
  349s   if re.search("^\s*%s\s*=" % (field), line):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:345: SyntaxWarning: invalid escape sequence '\('
  349s   re.match('^\(' + exe + '\)', tmp[0]):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:345: SyntaxWarning: invalid escape sequence '\)'
  349s   re.match('^\(' + exe + '\)', tmp[0]):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:734: SyntaxWarning: invalid escape sequence '\('
  349s   if re.search('%s \(' % path, line):
  349s Traceback (most recent call last):
  349s   File "/tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/test-open-iscsi.py", line 50, in <module>
  349s     import testlib
  349s   File "/tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py", line 23, in <module>
  349s     import crypt
  349s ModuleNotFoundError: No module named 'crypt'
  349s autopkgtest [10:06:36]: test testsuite: -----------------------]
  350s autopkgtest [10:06:37]: test testsuite:  - - - - - - - - - - results - - - - - - - - - -
  350s testsuite            FAIL non-zero exit status 1

  
  This is not considered a regression due to python3-defaults because open-iscsi also fails its autopkgtest when triggered by migration-reference/0, and has been doing so for a long time (at least since April 2024 in Noble). 

  [1] https://autopkgtest.ubuntu.com/packages/open-iscsi/plucky/amd64

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/2095584/+subscriptions