[Bug 2095584] Re: open-iscsi: ubuntu-only test needs update for Python 3.13

[Christian Ehrhardt]

Now it is over the syntax errors and similar, but breaks on being unable
to handle plucky images.

...
unable to find kernel in /tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img
setUpClass (__main__.CloudImageTest) ... ERROR

======================================================================
ERROR: setUpClass (__main__.CloudImageTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/test-open-iscsi.py", line 241, in setUpClass
    patch_image(info['root_image'],
    ~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
                kernel=info['kernel'], initrd=info['initrd'])
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/test-open-iscsi.py", line 381, in patch_image
    subprocess.check_call(cmd)
    ~~~~~~~~~~~~~~~~~~~~~^^^^^
  File "/usr/lib/python3.13/subprocess.py", line 419, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['patch-image', '/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img', '--kernel=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/kernel', '--initrd=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/initrd']' returned non-zero exit status 1.

This is in a callout to:
patch-image /tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img --kernel=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/kernel --initrd=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/initrd

Which is part of the testing scripts as well in debian/tests/patch-image

Reproducible in the autopkgtest environment:

ubuntu at autopkgtest:/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests$ sudo ./patch-image /tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img --kernel=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/kernel --initrd=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/initrd
mic /tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img -- ./patch-image _MOUNTPOINT_ --kernel=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/kernel --initrd=/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/initrd
no packages or debs given, using packages=open-iscsi
sed: can't read /etc/apt/sources.list: No such file or directory
writing network to /tmp/mount-image-callback.Fc7Kp2/mp/lib/systemd/system/xdebug-network.service
writing local-fs to /tmp/mount-image-callback.Fc7Kp2/mp/lib/systemd/system/xdebug-local-fs.service
1 packages: open-iscsi
+ mypkg=none
+ shift
+ apt-get update -q
Get:1 http://archive.ubuntu.com/ubuntu plucky InRelease [249 kB]
Hit:2 http://archive.ubuntu.com/ubuntu plucky-updates InRelease
Hit:3 http://archive.ubuntu.com/ubuntu plucky-security InRelease
Get:4 http://archive.ubuntu.com/ubuntu plucky/universe Sources [20.8 MB]
Get:5 http://archive.ubuntu.com/ubuntu plucky/universe amd64 Packages [16.0 MB]
Fetched 37.1 MB in 8s (4689 kB/s)
Reading package lists...
+ [ none != none ]
+ apt-get install -qy --only-upgrade open-iscsi
Reading package lists...
Building dependency tree...
Reading state information...
open-iscsi is already the newest version (2.1.10-3ubuntu1).
0 upgraded, 0 newly installed, 0 to remove and 165 not upgraded.
0 debs: 
unable to find kernel in /tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests/plucky.d/disk.img
ubuntu at autopkgtest:/tmp/autopkgtest.r8RVcA/build.x7y/src/debian/tests$ echo $?
1


I've pushed the fixups to debian/tests/testlib.py to https://code.launchpad.net/~paelzer/ubuntu/+source/open-iscsi/+git/open-iscsi/+ref/lp2095584-strip-fix-testlib so anyone can continue as my time before meetings runs out.

-- 
You received this bug notification because you are a member of Ubuntu
Foundations Bugs, which is subscribed to open-iscsi in Ubuntu.
https://bugs.launchpad.net/bugs/2095584

Title:
  open-iscsi: ubuntu-only test needs update for Python 3.13

Status in open-iscsi package in Ubuntu:
  New
Status in python3-defaults package in Ubuntu:
  New

Bug description:
  open-iscsi fails its autopkgtest [1] when triggered by
  python3-defaults/3.13.1-1~exp2 (i.e. with python3.13 as the default
  Python interpreter).

  348s autopkgtest [10:06:35]: test testsuite: [-----------------------
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:151: SyntaxWarning: invalid escape sequence '\s'
  349s   if re.search("^\s*%s\s*=" % (field), line):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:170: SyntaxWarning: invalid escape sequence '\s'
  349s   if re.search("^\s*%s\s*=" % (field), line):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:345: SyntaxWarning: invalid escape sequence '\('
  349s   re.match('^\(' + exe + '\)', tmp[0]):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:345: SyntaxWarning: invalid escape sequence '\)'
  349s   re.match('^\(' + exe + '\)', tmp[0]):
  349s /tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py:734: SyntaxWarning: invalid escape sequence '\('
  349s   if re.search('%s \(' % path, line):
  349s Traceback (most recent call last):
  349s   File "/tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/test-open-iscsi.py", line 50, in <module>
  349s     import testlib
  349s   File "/tmp/autopkgtest.j5qteT/build.Boe/src/debian/tests/testlib.py", line 23, in <module>
  349s     import crypt
  349s ModuleNotFoundError: No module named 'crypt'
  349s autopkgtest [10:06:36]: test testsuite: -----------------------]
  350s autopkgtest [10:06:37]: test testsuite:  - - - - - - - - - - results - - - - - - - - - -
  350s testsuite            FAIL non-zero exit status 1

  
  This is not considered a regression due to python3-defaults because open-iscsi also fails its autopkgtest when triggered by migration-reference/0, and has been doing so for a long time (at least since April 2024 in Noble). 

  [1] https://autopkgtest.ubuntu.com/packages/open-iscsi/plucky/amd64

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/open-iscsi/+bug/2095584/+subscriptions