Rietveld cleanup
John Arbash Meinel
john at arbash-meinel.com
Tue Sep 10 11:17:20 UTC 2013
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
...
>> Is that actually intended to be part of the workflow? It ends up
>> with several more clicks and delays for round trips (you have to
>> wait for your patch to land, then click back through and close
>> the Rietveld ticket, etc.)
>
> I just takes a second to close the CL after you submitted it for
> landing. Actually I always do that after I run "bzr rv-submit" on
> the approved branch.
There is a small issue that it isn't actually the right time to close
it (it should be closed when it has landed, not when submitted). I
find it interesting that you use rv-submit to handle the LP side of
things, and then manually click on a different website. It *is*
overhead. If it is worth doing, then we should ask everyone to do it,
I just question the premise that it is actually worth adding that
overhead to every submission.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (Cygwin)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlIu/8AACgkQJdeBCYSNAANUYQCfXrMNXRcaUQ8NnKHWzsimxwBz
KnIAoMh9Gpg3xFdWDbw//3QfqTj/6oFd
=SGaj
-----END PGP SIGNATURE-----
More information about the Juju-dev
mailing list