Landing bot merge commit messages need the PR title
Menno Smits
menno.smits at canonical.com
Mon Jun 9 05:39:30 UTC 2014
I've noticed that the commit messages for the merges performed by the Juju
bot don't include the PR title. This can lead to some slightly odd commit
logs.
For example, have a look at PR #13. The merge commit (d8a2c54) message
starts like this:
Merge pull request #13 from dimitern/501-use-networks-constraints
- in "juju deploy"
- update help topics
- change MachineConfig to only have Networks (to include)
...
The bullet list needs the context of the title. It would make more sense
like this:
Merge pull request #13 from dimitern/501-use-networks-constraints
*Start using networks constraints for deployments*
- in "juju deploy"
- update help topics
- change MachineConfig to only have Networks (to include)
...
Looking through the commit logs, most other merge commit messages would
have been clearer with the PR title. Is this easy to fix?
- Menno
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140609/d5fdd6b9/attachment.html>
More information about the Juju-dev
mailing list