Landing bot merge commit messages need the PR title

[Andrew Wilkins]

On Mon, Jun 9, 2014 at 1:39 PM, Menno Smits <menno.smits at canonical.com>
wrote:

> I've noticed that the commit messages for the merges performed by the Juju
> bot don't include the PR title. This can lead to some slightly odd commit
> logs.
>
> For example, have a look at PR #13. The merge commit (d8a2c54) message
> starts like this:
>
>     Merge pull request #13 from dimitern/501-use-networks-constraints
>
>     - in "juju deploy"
>     - update help topics
>     - change MachineConfig to only have Networks (to include)
>     ...
>
> The bullet list needs the context of the title. It would make more sense
> like this:
>
>     Merge pull request #13 from dimitern/501-use-networks-constraints
>
>     *Start using networks constraints for deployments*
>
>     - in "juju deploy"
>     - update help topics
>     - change MachineConfig to only have Networks (to include)
>     ...
>
>
> Looking through the commit logs, most other merge commit messages would
> have been clearer with the PR title. Is this easy to fix?
>

Looks fairly trivial:
https://github.com/juju/jenkins-github-lander/blob/develop/src/jenkinsgithublander/github.py#L134

Just need to add in pr["title"].

- Menno
>
>
>
>
>
> --
> Juju-dev mailing list
> Juju-dev at lists.ubuntu.com
> Modify settings or unsubscribe at:
> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140609/a72d5851/attachment.html>