Landing bot merge commit messages need the PR title

[Menno Smits]

I'm happy to make the change and test it, but what's the process for
getting it merged and deployed?


On 9 June 2014 19:22, Andrew Wilkins <andrew.wilkins at canonical.com> wrote:

> On Mon, Jun 9, 2014 at 1:39 PM, Menno Smits <menno.smits at canonical.com>
> wrote:
>
>> I've noticed that the commit messages for the merges performed by the
>> Juju bot don't include the PR title. This can lead to some slightly odd
>> commit logs.
>>
>> For example, have a look at PR #13. The merge commit (d8a2c54) message
>> starts like this:
>>
>>     Merge pull request #13 from dimitern/501-use-networks-constraints
>>
>>     - in "juju deploy"
>>     - update help topics
>>     - change MachineConfig to only have Networks (to include)
>>     ...
>>
>> The bullet list needs the context of the title. It would make more sense
>> like this:
>>
>>     Merge pull request #13 from dimitern/501-use-networks-constraints
>>
>>     *Start using networks constraints for deployments*
>>
>>     - in "juju deploy"
>>     - update help topics
>>     - change MachineConfig to only have Networks (to include)
>>     ...
>>
>>
>> Looking through the commit logs, most other merge commit messages would
>> have been clearer with the PR title. Is this easy to fix?
>>
>
> Looks fairly trivial:
> https://github.com/juju/jenkins-github-lander/blob/develop/src/jenkinsgithublander/github.py#L134
>
> Just need to add in pr["title"].
>
> - Menno
>>
>>
>>
>>
>>
>> --
>> Juju-dev mailing list
>> Juju-dev at lists.ubuntu.com
>> Modify settings or unsubscribe at:
>> https://lists.ubuntu.com/mailman/listinfo/juju-dev
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju-dev/attachments/20140610/1285c1ce/attachment-0001.html>