[Review Queue] RSyslog, Rsyslog-Forwarder-HA, NRPE-External-Master, Transcode-Cluster

[Charles Butler]

Today I reviewed a few charms:

NRPE-External-master - which was a merge request to land some features
against the charm relating to conntrack integration.  I was a bit
disappointed with the status of the documentation of the
NRPE-External-Master charm as a whole and superimposed a blocker pending a
doc update for the proposed feature. Otherwise the code quality was good
and appears to have been deployed successfully - but I didn't know what to
do with the new config options so validation was tough.
https://code.launchpad.net/~chris-gondolin/charms/precise/nrpe-external-master/trunk/+merge/227530

Rsyslog -   Rsyslog was a request for promotion to trusty from the precise
series. As some of you may know that our policy has become stricter on
~charmer recommended charms in the trusty series with a focus on tests
(which rsyslog has!). However the charm needs a bit of house keeping before
it can be accepted but is very close to being ready for trusty inclusion.
 Lets give Jorge Niedbalski a quick hi5 for stepping up to take over this
charms maintainership.
 https://bugs.launchpad.net/charms/+source/rsyslog/+bug/1355987
<https://bugs.launchpad.net/charms/+source/rsyslog/+bug/1355987rsyslog-forwarder-ha>

Rsyslog-Forwarder-HA -  see: rsyslog.

The forwarder-ha charm has passed my trusty audit, and when the precise
charm is forked as a trusty series and deployed - things work out of the
box. I'm promoting this to trusty and the rsyslog charm will be following
soon (niedbalski is a very responsive charmer)

https://bugs.launchpad.net/charms/+source/rsyslog-forwarder-ha/+bug/1355988


Transcode-Cluster:
This bundle works a treat - It has a reference to a personal namespace
charm, which would need to be updated.

However it does not pass bundle proof - and this may speak to an issue in
our tooling as this supports MAAS tagging, but our linting tool does not:

W: transcode: charm URL should include a revision
W: transcode: charm URL should include a revision
E: orange-box/nfs: unsupported constraints: tags
E: orange-box/transcode: unsupported constraints: tags


I'm leaving a comment about this, and referencing the charm should be
updated for the store once it is promulgated and moving on a conversation
with bug reported against charm-tools.
https://bugs.launchpad.net/charm-tools/+bug/1360374


All the best,

Charles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20140822/a89273f2/attachment.html>