[Review Queue] - kafka, kibana, apache2 x2, mariadb, memcached

[Andrew Mcleod]

It's that time again; the Big Data team had a go at the review queue, and
here's what we came up with:



   -

   kafka
   -


      https://code.launchpad.net/~merlijn-sebrechts/charms/trusty/apache-kafka/trunk/+merge/276647
      -

      New actions and upstart job work as expected
      -

      Merged with some minor modifications to advertised.host.name logic
      -

   kibana 4
   -


      https://code.launchpad.net/~canonical-is-sa/charms/trusty/kibana/kibana4/+merge/276944
      -

      Tests passed with no problems.
      -

      Quick code review was fine.
      -

      +1, merged
      -

   apache2 * (apt-source)
   -


      https://code.launchpad.net/~evarlast/charms/trusty/apache2/trunk/+merge/278220
      -

      Tests related to new config values failing (apt-source)
      -

      Older tests failing with an assert_called_once error
      -

      Unfortunately with so many test failures, I can’t proceed any further
      with this review
      -

   apache2 * (add-logs-interface)
   -
      https://code.launchpad.net/~evarlast/charms/trusty/apache2/add-logs-interface/+merge/278222
      -

      This one is failing on some of the same issues as the apt-source
      review, but others have been fixed - if these are fixed and merged into
      apt-source, that will be fixed reviews leaving only the two stale cert
      tests to resolve.
      -


      https://code.launchpad.net/~evarlast/charms/trusty/apache2/add-logs-interface/+merge/278222
      -

   mariadb
   -

      https://bugs.launchpad.net/charms/+bug/1517165
      -

      This is an update to refresh the MariaDB enterprise repo
      -

      We would like to see both consumer and enterprise versions of mariadb
      made available.  If deployed with correct enterprise options,
installation
      would occur from the special repo; otherwise, install from the ubuntu
      archives.
      -

      Not merged for now, pending the outcome of our discussion in the bug.
      -

   memcached (local-monitor interface)
   -


      https://code.launchpad.net/~brad-marshall/charms/trusty/memcached/add-monitors-relation/+merge/276958
      -

      The charm tests fail. Test 10_deploy_test.py tries to telnet to a
      port closed by the firewall of memcached. We opened a bug for this issue:
      https://bugs.launchpad.net/charms/+source/memcached/+bug/1525026
      -

      At this point we cannot proceed with the merge, because we cannot be
      sure we do not break something else. Also, we did not spot any tests
      dedicated to the proposed functionality.


* As an addendum to both apache2 reviews, the author has proposed a fix and
hopefully these will be re-reviewed and merged soon.



Questions/comments? We're in #juju on irc.freenode.net

Thanks!
Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151211/65471499/attachment.html>