[Review Queue] - kafka, kibana, apache2 x2, mariadb, memcached

[Felipe Reyes]

Hi Andrew,

On Fri, 11 Dec 2015 17:37:16 +0100
Andrew Mcleod <andrew.mcleod at canonical.com> wrote:

>    memcached (local-monitor interface)
>    -
> 
> 
>       https://code.launchpad.net/~brad-marshall/charms/trusty/memcached/add-monitors-relation/+merge/276958
>       -
> 
>       The charm tests fail. Test 10_deploy_test.py tries to telnet to
> a port closed by the firewall of memcached. We opened a bug for this
> issue:
> https://bugs.launchpad.net/charms/+source/memcached/+bug/1525026 -
> 
>       At this point we cannot proceed with the merge, because we
> cannot be sure we do not break something else. Also, we did not spot
> any tests dedicated to the proposed functionality.

I just proposed a patch that fixes[0] the tests, sorry for not noticing
before that the amulet tests were broken.

Best Regards,

[0] https://code.launchpad.net/~freyes/charms/trusty/memcached/lp1525026/+merge/281254
-- 
Felipe Reyes
# Email: felipe.reyes at canonical.com (GPG:0x9B1FFF39)
# Launchpad: ~freyes | IRC: freyes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/juju/attachments/20151222/608494e3/attachment.pgp>