ACK/Cmnt: [F][PATCH 1/1] net/bpfilter: remove superfluous testing message

[Andrea Righi]

On Tue, Apr 07, 2020 at 10:13:47AM +0200, Thomas Lamprecht wrote:
> From: Bruno Meneguele <bmeneg at redhat.com>
> 
> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
> usage for /dev/kmsg") but should've been deleted before patch submission.
> Although it doesn't cause any harm to the code or functionality itself, it's
> totally unpleasant to have it displayed on every loop iteration with no real
> use case. Thus remove it unconditionally.
> 
> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
> Signed-off-by: Bruno Meneguele <bmeneg at redhat.com>
> Signed-off-by: David S. Miller <davem at davemloft.net>

It's missing the cherry picked line:

(cherry picked from commit 41c55ea6c2a7ca4c663eeec05bdf54f4e2419699)

But it can be easily adjusted when applying the patch. Apart than that
it looks good to me, therefore:

Acked-by: Andrea Righi <andrea.righi at canonical.com>

> Signed-off-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> ---
>  net/bpfilter/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
> index efea4874743e..05e1cfc1e5cd 100644
> --- a/net/bpfilter/main.c
> +++ b/net/bpfilter/main.c
> @@ -35,7 +35,6 @@ static void loop(void)
>  		struct mbox_reply reply;
>  		int n;
>  
> -		fprintf(debug_f, "testing the buffer\n");
>  		n = read(0, &req, sizeof(req));
>  		if (n != sizeof(req)) {
>  			fprintf(debug_f, "invalid request %d\n", n);
> -- 
> 2.20.1
> 
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team