ACK/Cmnt: [F][PATCH 1/1] net/bpfilter: remove superfluous testing message

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 7 09:31:56 UTC 2020


On 4/7/20 11:27 AM, Andrea Righi wrote:
> On Tue, Apr 07, 2020 at 10:13:47AM +0200, Thomas Lamprecht wrote:
>> From: Bruno Meneguele <bmeneg at redhat.com>
>>
>> A testing message was brought by 13d0f7b814d9 ("net/bpfilter: fix dprintf
>> usage for /dev/kmsg") but should've been deleted before patch submission.
>> Although it doesn't cause any harm to the code or functionality itself, it's
>> totally unpleasant to have it displayed on every loop iteration with no real
>> use case. Thus remove it unconditionally.
>>
>> Fixes: 13d0f7b814d9 ("net/bpfilter: fix dprintf usage for /dev/kmsg")
>> Signed-off-by: Bruno Meneguele <bmeneg at redhat.com>
>> Signed-off-by: David S. Miller <davem at davemloft.net>
> It's missing the cherry picked line:
> 
> (cherry picked from commit 41c55ea6c2a7ca4c663eeec05bdf54f4e2419699)
> 
> But it can be easily adjusted when applying the patch. Apart than that
> it looks good to me, therefore:
> 
> Acked-by: Andrea Righi <andrea.righi at canonical.com>
> 

Ah yeah, sure! Sorry about that, it's because I applied with `git am` not with
`git cherry-pick -xs` like normally, as I did not had Dave's net tree directly
available and was to lazy to add and fetch it as I had the patch already from
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/patch/?id=41c55ea6c2a7ca4c663eeec05bdf54f4e2419699

oops, adjusted when applying the patch or works both for me :)




More information about the kernel-team mailing list