NACK/Cmnt: [SRU][canonical-kernel-snap/main] nvidia-hooks: fix nvidia-ko

[Stefan Bader]

On 18.02.25 23:26, Aaron Jauregui wrote:
> On Tue, Feb 18, 2025 at 03:49:01PM +0100, Stefan Bader wrote:
>> Rejected for the following reasons:
>> - Patch does not apply. Please re-submit once you refreshed the repo
>>
>> Hunk #1 FAILED at 6.
>> 1 out of 1 hunk FAILED
>> checking file hooks/module/post-refresh.module
>> Hunk #1 FAILED at 6.
>> 1 out of 1 hunk FAILED
>> checking file hooks/module/remove.module
>> Hunk #1 FAILED at 4.
>> 1 out of 1 hunk FAILED
>> checking file hooks/nvidia-ko/install.nvidia-ko
>> Hunk #1 FAILED at 5.
>> Hunk #2 FAILED at 22.
>> 2 out of 2 hunks FAILED
>> checking file hooks/nvidia-ko/post-refresh.nvidia-ko
>> checking file hooks/nvidia-ko/remove.nvidia-ko
>> checking file hooks/nvidia-user/install.nvidia-user
>> Hunk #1 FAILED at 6.
>> 1 out of 1 hunk FAILED
>> checking file hooks/nvidia-user/kernel-gpu-2404-provider-mangler
>> Hunk #1 FAILED at 1.
>> 1 out of 1 hunk FAILED
>> checking file hooks/nvidia-user/remove.nvidia-user
>> checking file hooks/pc-kernel/install.pc-kernel
>> Hunk #1 FAILED at 1.
>> 1 out of 1 hunk FAILED
>> checking file hooks/pc-kernel/post-refresh.pc-kernel
>> Hunk #1 FAILED at 1.
>> 1 out of 1 hunk FAILED
> 
> It seems like I'm missing something here. I'm trying to figure out why
> the patchset caused this error but I can't seem to reproduce it. I tried
> to git am the patch onto a fresh copy of the canonical-kernel-snaps repo
> and it seems to be applying cleanly on my end. Could you please help point
> me in the right direction? Apologies for the issue.

Hm, I am not sure this is a new "feature" of recent Thunderbird / 
ImportExportTools NG or some incompatibility with the upside down world 
but when I export your patches they get mangled at indentation level. 
The lines of context get an extra space and some removal lines loose all 
spaces... with the re-submissions I had the same issue. But even 
cut&paste from the shared inbox works correctly... so at least I have 
something I could apply now...

Sorry, problem is on my side...

-Stefan

> 
> Cheers, Aaron
> 
> 


-- 
- Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 47863 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250225/66e083a4/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250225/66e083a4/attachment-0001.sig>