NACK[O]+Cmnt[N]: [SRU N/O/P][PATCH 00/15] Patch Request for HPE iLO7 VGA device for Gen12 Servers
Stefan Bader
stefan.bader at canonical.com
Fri Jun 27 08:28:02 UTC 2025
On 26.06.25 19:26, Michael Reed wrote:
> Hi Stefan,
>
> I have moved Noble to "won't fix" so go ahead and nack Noble. I will
> stick with Plucky. Can we keep the patch pull here or should I
> create a new submission with Plucky only for the malling list?
I tried to make the current submission go ahead for P by acking it. Plan
is to keep this submission active for P. Let me add the NACK for N with
a comment and see how it goes.
-Stefan
>
> Regards,
> Michael
>
> On Mon, Jun 23, 2025 at 7:58 AM Stefan Bader <stefan.bader at canonical.com
> <mailto:stefan.bader at canonical.com>> wrote:
>
> On 18.06.25 18:23, Michael Reed wrote:
> > Hi Stefan,
> >
> > That is fair, I will follow up with HPE on a more elaborate test
> plan.
> > What are the chances this can still be accepted into plucky as it is
> > just one patch? If it is in HWE, that gives HPE something to
> work with.
>
> I am not at all opposed on the on-patch change to Plucky. I would even
> prefer to keep it just there. After all that is the reason the HWE
> kernel exists. To support newer HW which requires more than the usual
> small quirks. As the more change is required for support the less
> likely
> it is reasonable to backport (primary goal for limiting change is to
> avoid regressions or other risk in a released series).
>
> >
> > Regards,
> > Michael
> >
> > On Wed, Jun 18, 2025 at 7:03 AM Stefan Bader
> <stefan.bader at canonical.com <mailto:stefan.bader at canonical.com>
> > <mailto:stefan.bader at canonical.com
> <mailto:stefan.bader at canonical.com>>> wrote:
> >
> > On 17.06.25 21:35, Michael Reed wrote:
> > > From: Michael Reed <Michael.Reed at canonical.com
> <mailto:Michael.Reed at canonical.com>
> > <mailto:Michael.Reed at canonical.com
> <mailto:Michael.Reed at canonical.com>>>
> > >
> > > BugLink: https://bugs.launchpad.net/bugs/2114516 <https://
> bugs.launchpad.net/bugs/2114516> <https://
> > bugs.launchpad.net/bugs/2114516 <http://bugs.launchpad.net/
> bugs/2114516>>
> > >
> > > SRU Justification:
> > >
> > > [Impact]
> > > HPE is requesting to Add support for the new device
> G200eH5. This
> > is needed for the iLO7 VGA device on there Gen 12 Servers.
> > >
> > > [Fix]
> > > 2e367ad4da33 drm/mgag200: convert get modes to struct drm_edid
> > (v6.9-rc1)
> > > *225a8d0bd93e drm/ast: Implement polling for VGA and SIL164
> > connectors (v6.10-rc1)
> > > ecde5db1598a drm/mgag200: Set DDC timeout in milliseconds
> (v6.11-rc1)
> > > eb1ae34e48a0 drm/mgag200: Bind I2C lifetime to DRM device
> (v6.11-rc1)
> > > 23368d7b9c1a drm/mgag200: Store pointer to struct
> mga_device in
> > struct mga_i2c_chan (v6.11-rc1)
> > > f2e9952449c0 drm/mgag200: Allocate instance of struct
> > mga_i2c_chan dynamically (v6.11-rc1)
> > > 21cd078519ed drm/mgag200: Inline mgag200_i2c_init()
> (v6.11-rc1)
> > > 814ebf50bb28 drm/mgag200: Replace struct mga_i2c_chan with
> struct
> > mgag200_ddc (v6.11-rc1)
> > > ddadc87f1498 drm/mgag200: Rename mgag200_i2c.c to
> mgag200_ddc.c
> > (v6.11-rc1)
> > > b7e04af37edc drm/mgag200: Rename struct i2c_algo_bit_data
> > callbacks (v6.11-rc1)
> > > 66d58ec0bc65 drm/mgag200: Acquire I/O-register lock in DDC
> code
> > (v6.11-rc1)
> > > 46c131986030 drm/mgag200: Use drm_connector_helper_get_modes()
> > (v6.11-rc1)
> > > 579d47838b56 drm/mgag200: Consolidate VGA output (v6.11-rc1)
> > > 202fe72cce42 drm/mgag200: Add BMC output (v6.11-rc1)
> > > f5510726608f drm/mgag200: Add VGA-BMC output (v6.12-rc1)
> > > dc06efbb7934 drm/mgag200: vga-bmc: Transparently handle BMC
> > (v6.12-rc1)
> > > 6636c58b946c drm/mgag200: Added support for the new device
> > G200eH5 (v6.15-rc1)
> > >
> > > [Test Plan]
> > >
> > > Test the loading of the driver.
> > >
> > > - Reboot the system multiple times to check if the driver load
> > correctly without error
> > >
> > > - Test vga driver in GUI mode to check if it works with the
> > resolution change of a display without problem.
> > >
> > >
> > > [Where problems could occur]
> > >
> > > [Other Info]
> > > Noble
> > > https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/ <https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/>
> > noble/+ref/lp_2098064_matrox_2 <https://code.launchpad.net/
> <https://code.launchpad.net/>
> > ~mreed8855/ubuntu/+source/linux/+git/noble/+ref/
> lp_2098064_matrox_2>
> > (15 patches)
> > >
> > > Oracular
> > > https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/ <https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/>
> > oracular/+ref/lp_2098064_matrox_2 <https://
> code.launchpad.net/ <https://code.launchpad.net/>
> > ~mreed8855/ubuntu/+source/linux/+git/oracular/+ref/
> > lp_2098064_matrox_2> (3 patches)
> > >
> > > Plucky
> > > https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/ <https://code.launchpad.net/~mreed8855/ubuntu/+source/
> linux/+git/>
> > plucky/+ref/lp_2098064_matrox_3 <https://code.launchpad.net/
> <https://code.launchpad.net/>
> > ~mreed8855/ubuntu/+source/linux/+git/plucky/+ref/
> > lp_2098064_matrox_3> (1 patch)
> > >
> > >
> > > The following changes since commit
> > a4f4e7fc71b7efdc6f7382e99ed8651fb0208104:
> > >
> > > drm/mgag200: convert get modes to struct drm_edid
> (2025-06-13
> > 16:20:48 -0500)
> > >
> > > are available in the Git repository at:
> > >
> > > https://git.launchpad.net/~mreed8855/ubuntu/+source/linux/
> +git/ <https://git.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/>
> > noble <https://git.launchpad.net/~mreed8855/ubuntu/+source/
> linux/ <https://git.launchpad.net/~mreed8855/ubuntu/+source/linux/>
> > +git/noble> lp_2098064_matrox_2
> > >
> > > for you to fetch changes up to
> > 08aeb09c51449a972ac816a621842f7c4553b289:
> > >
> > > drm/mgag200: Added support for the new device G200eH5
> > (2025-06-13 16:26:56 -0500)
> > >
> > >
> ----------------------------------------------------------------
> > > Gwenael Georgeault (1):
> > > drm/mgag200: Added support for the new device G200eH5
> > >
> > > Thomas Zimmermann (13):
> > > drm/ast: Implement polling for VGA and SIL164
> connectors
> > > drm/mgag200: Store pointer to struct mga_device in
> struct
> > mga_i2c_chan
> > > drm/mgag200: Allocate instance of struct mga_i2c_chan
> > dynamically
> > > drm/mgag200: Inline mgag200_i2c_init()
> > > drm/mgag200: Replace struct mga_i2c_chan with struct
> > mgag200_ddc
> > > drm/mgag200: Rename mgag200_i2c.c to mgag200_ddc.c
> > > drm/mgag200: Rename struct i2c_algo_bit_data callbacks
> > > drm/mgag200: Acquire I/O-register lock in DDC code
> > > drm/mgag200: Use drm_connector_helper_get_modes()
> > > drm/mgag200: Consolidate VGA output
> > > drm/mgag200: Add BMC output
> > > drm/mgag200: Add VGA-BMC output
> > > drm/mgag200: vga-bmc: Transparently handle BMC
> > >
> > > drivers/gpu/drm/ast/ast_mode.c | 10 +-
> > > drivers/gpu/drm/drm_probe_helper.c | 29 +++++
> > > drivers/gpu/drm/mgag200/Makefile | 7 +-
> > > drivers/gpu/drm/mgag200/mgag200_bmc.c | 107 ++++++++
> ++++++++
> > > drivers/gpu/drm/mgag200/mgag200_ddc.c | 179 ++++++++
> +++++++
> > +++++++++++
> > > drivers/gpu/drm/mgag200/mgag200_ddc.h | 11 ++
> > > drivers/gpu/drm/mgag200/mgag200_drv.c | 4 +
> > > drivers/gpu/drm/mgag200/mgag200_drv.h | 52 ++++----
> > > drivers/gpu/drm/mgag200/mgag200_g200.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200eh.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200eh3.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200eh5.c | 204 ++++++++
> +++++++
> > +++++++++++++++
> > > drivers/gpu/drm/mgag200/mgag200_g200er.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200ev.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200ew3.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200se.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_g200wb.c | 45 +------
> > > drivers/gpu/drm/mgag200/mgag200_i2c.c | 131
> -------------------
> > > drivers/gpu/drm/mgag200/mgag200_mode.c | 27 +---
> > > drivers/gpu/drm/mgag200/mgag200_vga.c | 68 ++++++++++
> > > drivers/gpu/drm/mgag200/mgag200_vga_bmc.c | 118 ++++++++
> +++++++++
> > > include/drm/drm_probe_helper.h | 4 +
> > > 22 files changed, 789 insertions(+), 522 deletions(-)
> > > create mode 100644 drivers/gpu/drm/mgag200/mgag200_ddc.c
> > > create mode 100644 drivers/gpu/drm/mgag200/mgag200_ddc.h
> > > create mode 100644 drivers/gpu/drm/mgag200/mgag200_g200eh5.c
> > > delete mode 100644 drivers/gpu/drm/mgag200/mgag200_i2c.c
> > > create mode 100644 drivers/gpu/drm/mgag200/mgag200_vga.c
> > > create mode 100644 drivers/gpu/drm/mgag200/mgag200_vga_bmc.c
> > >
> > Oracular will receive no more functional updates, it goes EOL
> early
> > July. On the noble backport: that is quite a bunch of changes.
> > Especially since that mgag200 chip is widely used in newer
> BMCs (not
> > only the ones from HP). That should get a bit more testing
> than "the
> > driver loads" and potentially on different BMCs using that
> graphics
> > chip.
> >
> > --
> > - Stefan
> >
>
>
> --
> - Stefan
>
--
- Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 47863 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250627/c91dfac7/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250627/c91dfac7/attachment-0001.sig>
More information about the kernel-team
mailing list