[Merge] lp:~brian-murray/ubuntu-archive-tools/srus-fix-committed into lp:ubuntu-archive-tools

[Brian Murray]

Brian Murray has proposed merging lp:~brian-murray/ubuntu-archive-tools/srus-fix-committed into lp:ubuntu-archive-tools.

Requested reviews:
  Ubuntu Package Archive Administrators (ubuntu-archive)

For more details, see:
https://code.launchpad.net/~brian-murray/ubuntu-archive-tools/srus-fix-committed/+merge/296742

Sometimes an SRU doesn't fix all the bugs it intended to so another SRU is uploaded to supersede the previous one.  In that case some bug tasks in Launchpad will already be "Fix Committed" but given my change that added code to create a source package release task in a bug that does not have one we end up with this Traceback:

Traceback (most recent call last):
  File "./sru-review", line 448, in <module>
    process_bug(launchpad, upload, bug_num)
  File "./sru-review", line 266, in process_bug
    new_task = bug.addTask(target=sourcepkg_target)
  File "/usr/lib/python2.7/dist-packages/lazr/restfulclient/resource.py", line 609, in __call__
    extra_headers=extra_headers)
  File "/usr/lib/python2.7/dist-packages/lazr/restfulclient/_browser.py", line 426, in _request
    raise error
lazr.restfulclient.errors.BadRequest: HTTP Error 400: Bad Request
Response headers:
---
-content-encoding: gzip
connection: close
content-length: 72
content-type: text/plain
date: Tue, 07 Jun 2016 21:54:14 GMT
server: zope.server.http (HTTP)
status: 400
strict-transport-security: max-age=15552000
vary: Accept,Accept-Encoding
x-content-type-options: nosniff
x-frame-options: SAMEORIGIN
x-lazr-notifications: []
x-powered-by: Zope (www.zope.org), Python (www.python.org)
x-xss-protection: 1; mode=block
---
Response body:
---
A fix for this bug has already been requested for snapd in Ubuntu Xenial

This fixes that by not exiting if the task's status is already "Fix Committed".
-- 
Your team Ubuntu Package Archive Administrators is requested to review the proposed merge of lp:~brian-murray/ubuntu-archive-tools/srus-fix-committed into lp:ubuntu-archive-tools.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 2371 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-archive/attachments/20160607/c6cef0a0/attachment.diff>