[Merge] lp:~artmello/webbrowser-app/webbrowser-app-swipe_to_delete into lp:webbrowser-app

[Olivier Tilloy]

Review: Needs Fixing

I’m seeing one additional issue, which I don’t think is a blocker but for which we can improve slightly the situation I believe.

I’ve been running autopilot tests on my desktop yesterday, and some of the autopilot tests insert history entries directly into the database by issuing SQL insertions. However the corresponding SQL statements weren’t updated to include the domain when the column was added, and as a result, when deleting a domain from the history, it is correctly removed from the model, but not from the DB (because the SQL command used is "DELETE FROM history WHERE domain=?;"). So if I quit the browser and launch it again, those domains will be back in the history.

I don’t think we can easily solve the general case (where people have old history databases), but at the very least we can update the autopilot test to insert the domains: you’ll need to add the domains to tests/autopilot/webbrowser_app/tests/test_history.py.
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-swipe_to_delete/+merge/229550
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.