[Merge] lp:~artmello/webbrowser-app/webbrowser-app-swipe_to_delete into lp:webbrowser-app

Olivier Tilloy olivier.tilloy at canonical.com
Thu Aug 14 06:15:19 UTC 2014


115	+    // If the rowCount is zero all the history entries of this model were
116	+    // removed. If that happens this domain will be removed of the list
117	+    // and we don't need to update it.

s/of the list/from the list/

I’d update the comment: it’s not that we don’t *need* to update it: if we update it, the model breaks. So I’d use stronger words to explain what happens, something along the lines of:

    If that happens this domain will be removed from the list, so we shouldn’t update its properties lest the update triggers a re-ordering while removing an entry.
-- 
https://code.launchpad.net/~artmello/webbrowser-app/webbrowser-app-swipe_to_delete/+merge/229550
Your team Ubuntu Phablet Team is subscribed to branch lp:webbrowser-app.



More information about the Ubuntu-reviews mailing list