[Merge] lp:~michael-sheldon/ubuntu-keyboard/fix-1365014 into lp:ubuntu-keyboard

Marco Trevisan (Treviño) mail at 3v1n0.net
Fri Sep 26 17:06:17 UTC 2014


I'm not into this codebase at all, but I was just wondering if each CharKey might check if it's the first or the last of its parent children, to initialize leftSide and rightSide... Indeed this way is cheaper, but probably harder to maintain.
-- 
https://code.launchpad.net/~michael-sheldon/ubuntu-keyboard/fix-1365014/+merge/236155
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~michael-sheldon/ubuntu-keyboard/fix-1365014 into lp:ubuntu-keyboard.



More information about the Ubuntu-reviews mailing list