[Merge] lp:~michael-sheldon/ubuntu-keyboard/fix-1365014 into lp:ubuntu-keyboard
Michael Sheldon
michael.sheldon at canonical.com
Fri Sep 26 17:56:52 UTC 2014
Hi Marco, I did wonder about something like that but I wasn't really comfortable making the assumption that the parent would necessarily be a row, or that this approach would make sense for all layouts (I think this might have caused issues with the proposed Japanese layout for example if it were not for the fact that uses some custom key implementations instead of CharKeys, but future layouts may still have fallen foul of it).
--
https://code.launchpad.net/~michael-sheldon/ubuntu-keyboard/fix-1365014/+merge/236155
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~michael-sheldon/ubuntu-keyboard/fix-1365014 into lp:ubuntu-keyboard.
More information about the Ubuntu-reviews
mailing list