[Merge] lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app

Brendan Donegan brendan.donegan at canonical.com
Wed Apr 29 09:56:12 UTC 2015


Review: Needs Information

I'm inclined to agree with veebers - single issue changes please to avoid the chance of unrelated things blocking the merge approval (see how it is already :P). Also the mix of specifying the base class as a variable and also directly is a little jarring - couldn't you make it a class attribute or 'constant' (i.e. PROXY_BASE = ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase at the file level)
-- 
https://code.launchpad.net/~canonical-platform-qa/camera-app/fix_base_class/+merge/257658
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app.



More information about the Ubuntu-reviews mailing list