[Merge] lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app
Leo Arias
leo.arias at canonical.com
Wed Apr 29 14:43:16 UTC 2015
> Also the mix of specifying the base class as a variable and also directly
> is a little jarring - couldn't you make it a class attribute or 'constant'
> (i.e. PROXY_BASE = ubuntuuitoolkit.UbuntuUIToolkitCustomProxyObjectBase at the
> file level)
That's an alias, because the name is too big to fit the 88 columns.
A constant works well too, so pushed.
Maybe we need to add a shorter alias directly on the toolkit.
--
https://code.launchpad.net/~canonical-platform-qa/camera-app/fix_base_class/+merge/257658
Your team Ubuntu Phablet Team is requested to review the proposed merge of lp:~canonical-platform-qa/camera-app/fix_base_class into lp:camera-app.
More information about the Ubuntu-reviews
mailing list