[Merge] lp:~phablet-team/qt-halide/unit-tests into lp:qt-halide

Florian Boucault florian.boucault at canonical.com
Fri Mar 27 10:44:15 UTC 2015


Review: Needs Fixing

15) Each class should have at least a separate unit tests file, e.g. HalideImageRenderer does not

16) tst_image.qml: setSourceAndCheckStatus() should be a method of input

17) tst_image.qml: test_image_renderer tests multiple cases, should be split in as many tests

18) there should be a "test" target showing up in QtCreator and it should be possible to run it in debug mode

19) tst_image.qml: test_missing & test_invalid check input.status twice

20) TestCase's name should match the name of the QML file they are in; "TransformInputTest" is used twice as a name

21) output is unreadable due to the many QDEBUG & QWARN

22) how do you run a single test case?

-- 
https://code.launchpad.net/~phablet-team/qt-halide/unit-tests/+merge/254064
Your team Ubuntu Phablet Team is subscribed to branch lp:~phablet-team/qt-halide/unit-tests.



More information about the Ubuntu-reviews mailing list