[Merge] lp:~sil2100/ubuntu-release-upgrader/package-section-fix into lp:ubuntu-release-upgrader

[Łukasz Zemczak]

Łukasz Zemczak has proposed merging lp:~sil2100/ubuntu-release-upgrader/package-section-fix into lp:ubuntu-release-upgrader.

Commit message:
New python3-apt bindings no longer provide Package.section, so switch to using Package.candidate.section whenever applicable. This fixes broken partial upgrades.

Requested reviews:
  Ubuntu Core Development Team (ubuntu-core-dev)
Related bugs:
  Bug #1841675 in ubuntu-release-upgrader (Ubuntu): "do-release-upgrade crashed with AttributeError in tryMarkObsoleteForRemoval(): 'Package' object has no attribute 'section'"
  https://bugs.launchpad.net/ubuntu/+source/ubuntu-release-upgrader/+bug/1841675

For more details, see:
https://code.launchpad.net/~sil2100/ubuntu-release-upgrader/package-section-fix/+merge/373868

New python3-apt bindings no longer provide Package.section, so switch to using Package.candidate.section whenever applicable. This fixes broken partial upgrades.

I have tested this on eoan by installing a package with lots of dependencies, removing it (leaving many unneeded packages) and additionally downgrading of some other package. Then I ran dist-upgrade.py --partial etc., first on the package as-is (reproducing the failure) and then with the changes applied. Seems to work as expected.

I guess Julian originally mentioned going through the list of versions (via Package.versions) to get the section match, but I think that's not needed here and Package.candidate is more than enough.
-- 
Your team Ubuntu Core Development Team is requested to review the proposed merge of lp:~sil2100/ubuntu-release-upgrader/package-section-fix into lp:ubuntu-release-upgrader.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: review-diff.txt
Type: text/x-diff
Size: 1745 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/ubuntu-reviews/attachments/20191009/f85250b7/attachment.diff>