[Merge] lp:~sil2100/ubuntu-release-upgrader/package-section-fix into lp:ubuntu-release-upgrader

[Julian Andres Klode]

Review: Needs Information



Diff comments:

> === modified file 'DistUpgrade/DistUpgradeCache.py'
> --- DistUpgrade/DistUpgradeCache.py	2019-09-10 15:47:31 +0000
> +++ DistUpgrade/DistUpgradeCache.py	2019-10-09 10:55:03 +0000
> @@ -938,7 +939,7 @@
>              return False
>          # ensure we honor KeepInstalledSection here as well
>          for section in self.config.getlist("Distro", "KeepInstalledSection"):
> -            if pkgname in self and self[pkgname].section == section:
> +            if pkgname in self and self[pkgname].candidate.section == section:

I'm not sure we always have a pkg.candidate here, it might be None. Since we are looking at packages to remove, should we look at .installed instead?

>                  logging.debug("skipping '%s' (in KeepInstalledSection)" % pkgname)
>                  return False
>          # if we don't have the package anyway, we are fine (this can


-- 
https://code.launchpad.net/~sil2100/ubuntu-release-upgrader/package-section-fix/+merge/373868
Your team Ubuntu Core Development Team is subscribed to branch lp:ubuntu-release-upgrader.