[Merge] ~enr0n/ubuntu/+source/systemd:ubuntu-lunar into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-lunar

[Lukas Märdian]

Review: Needs Fixing

Hi Nick! Thank you very much, this is looking good at first glance, skimming through it.

Here are my initial comments (more to come in a 2nd round review), let's also try to get those PPA autopkgtests fixed (upstream-2 & tests-in-lxd).


=== git diff pkg/import/252.1-1 -- . ':(exclude)debian/changelog' ':(exclude)debian/patches/*'

d/control:
+ systemd-sysv package => do we really need "Depends: systemd" if we have the pre-depends already? (well.. there's a versioned dependency..)

d/rules:
+ do we have any reference for that "CET on ubuntu amd64" enablement compiler issue/fix? we should add it to the comment

d/systemd.postinst:
+ I feel like we can drop all of that v234 delta, as we don't support upgrading from < Bionic to Lunar

d/systemd.prerm:
+ I don't think we support removing systemd at all... so I wonder why this file was dropped? Couldn't we just keep it, to reduce delta?

d/t/boot-and-services:
+ We should be able to unskip "test_service", as https://github.com/systemd/systemd/issues/20989 seems to be fixed in v251+

d/t/control:
+ boot-and-services: the "gdm3 [amd64]" dependency looks suspicious, why do we need to diverge from Debian here?
+ upstream-1, upstream-2: do we still need this libgcc-s1 test-dependency? Why isn't it needed in Debian? (maybe we should add a comment)

d/t/systemd-fsckd:
+ what's wrong with this test after all?? We're basically skipping/ignoring it, still we have a huge delta on it. This should probably be investigated in the future and we should drop the delta if we don't actually use it.


=== git diff pkg/ubuntu/devel -- debian/ ':(exclude)debian/patches/*'

d/t/control:
+ unit-tests: libqrencode-dev dependency on i386 (well.. I guess i386 adt tests are failing anyways...)
+ upstream-{1,2}: libqrencode-dev dependency on i386 (well.. I guess i386 adt tests are failing anyways...)
-- 
https://code.launchpad.net/~enr0n/ubuntu/+source/systemd/+git/systemd/+merge/433823
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-lunar.