[Merge] ~enr0n/ubuntu/+source/systemd:ubuntu-lunar into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-lunar

[Nick Rosbrook]

Thanks for taking a first pass!

> === git diff pkg/import/252.1-1 -- . ':(exclude)debian/changelog' ':(exclude)debian/patches/*'
> 
> d/control:
> + systemd-sysv package => do we really need "Depends: systemd" if we have the pre-depends already? (well.. there's a versioned dependency..)

Please see https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=d1ecf0c372f5212129c85ae60fddf26b2271a1fe.

> 
> d/rules:
> + do we have any reference for that "CET on ubuntu amd64" enablement compiler issue/fix? we should add it to the comment

I am not sure, the commit does not explain much: https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=cc42a377e7e8c372124bcf43d9f4fb9c169f4292.

> 
> d/systemd.postinst:
> + I feel like we can drop all of that v234 delta, as we don't support upgrading from < Bionic to Lunar

Good idea, thanks.

> 
> d/systemd.prerm:
> + I don't think we support removing systemd at all... so I wonder why this file was dropped? Couldn't we just keep it, to reduce delta?

Please see https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=0244c4d56556317f14eecc2f51871969ef02ba7b and bug 1758438.

> d/t/boot-and-services:
> + We should be able to unskip "test_service", as https://github.com/systemd/systemd/issues/20989 seems to be fixed in v251+

Good catch, thanks.

> 
> d/t/control:
> + boot-and-services: the "gdm3 [amd64]" dependency looks suspicious, why do we need to diverge from Debian here?

Please see https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=97cb13685dfb353045c449ec5d6d1df60f661079. It does not contain a lot of information or an LP, but I don't feel very strongly about removing that delta.

> + upstream-1, upstream-2: do we still need this libgcc-s1 test-dependency? Why isn't it needed in Debian? (maybe we should add a comment)

Yes, the package is definitely still needed, and I believe it is best to be explicit since pthread calls dlopen() on it. See https://github.com/systemd/systemd/pull/23858 and https://github.com/systemd/systemd/pull/24178 for background. I think Debian does not hit this because their autopkgtest does not run upstream tests AFAICT.

> 
> d/t/systemd-fsckd:
> + what's wrong with this test after all?? We're basically skipping/ignoring it, still we have a huge delta on it. This should probably be investigated in the future and we should drop the delta if we don't actually use it.

As far as why it's always skipped, it's because:

 autopkgtest [11:22:51]: test systemd-fsckd: [-----------------------
 SKIP: root file system is being checked by initramfs already
 autopkgtest [11:22:52]: test systemd-fsckd: -----------------------]

If it's always skipped in effect, maybe we can just drop the test entirely (and suggest that Debian does the same).

> 
> === git diff pkg/ubuntu/devel -- debian/ ':(exclude)debian/patches/*'
> 
> d/t/control:
> + unit-tests: libqrencode-dev dependency on i386 (well.. I guess i386 adt tests are failing anyways...)
> + upstream-{1,2}: libqrencode-dev dependency on i386 (well.. I guess i386 adt tests are failing anyways...)

Oh, yeah I didn't even notice. I will fix that for completeness though.

-- 
https://code.launchpad.net/~enr0n/ubuntu/+source/systemd/+git/systemd/+merge/433823
Your team Ubuntu Core Development Team is subscribed to branch ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-lunar.